Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify string insert text for array and property #29

Merged

Conversation

p-spacek
Copy link
Collaborator

What does this PR do?

copy of: redhat-developer#934

unify string text inserting for array and property

when you choose string property from completion you get
na -> name:

but for array, it generated extra quotes:
arr ->

array:
  - ""

These extra quotes caused, that it wasn't possible to invoke completion just after the code insert, but you had to delete "" continue...

the behavior is just a little bit different than for property text inserting.

Screen.Recording.2023-11-08.at.15.14.12.mov

Note that I didn't change it for number nor for bool because it seems to me a little bit different scenario

What issues does this PR fix or reference?

Is it tested? How?

update current tests

@p-spacek p-spacek merged commit 8f2aef5 into jigx May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant